Skip to content

Migrate from npm to pnpm package manager #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented May 28, 2025

Overview

This PR migrates the project from npm to pnpm as the package manager. pnpm provides several advantages over npm:

  • Disk space efficiency: pnpm uses a content-addressable store to avoid duplicating dependencies
  • Fast installation: pnpm is typically faster than npm for both fresh installs and updates
  • Strict dependency management: pnpm creates a more accurate dependency structure that prevents accessing undeclared dependencies

Changes

  • Removed package-lock.json and added pnpm-lock.yaml
  • Updated .npmrc with pnpm-specific configuration while preserving existing settings
  • Updated Dockerfiles to install pnpm globally and use pnpm commands instead of npm
  • Updated GitHub Actions workflow to set up pnpm and adjust caching strategies
  • Updated various scripts and tools to use pnpm instead of npm
  • Updated package.json scripts to use pnpm syntax
  • Added documentation in README.md about the package manager change

Developer Actions Required

Developers will need to:

  1. Install pnpm globally: npm install -g pnpm
  2. Use pnpm instead of npm for all package management operations
  3. Run pnpm install after pulling this change

Testing Done

  • Generated pnpm-lock.yaml with all dependencies
  • Verified that scripts and references to npm are updated throughout the codebase
  • Updated CI workflows to use pnpm-compatible syntax and caching strategies

Related Issues

This change implements the npm to pnpm migration requested in the project requirements.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: maor-rozenfeld <49363375+maor-rozenfeld@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Migrate from npm to pnpm (Dockerfiles, workflows, and lockfiles) Migrate from npm to pnpm package manager May 28, 2025
@Copilot Copilot AI requested a review from maor-rozenfeld May 28, 2025 10:56
Copilot finished work on behalf of maor-rozenfeld May 28, 2025 10:56
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants